jenkins-bot has submitted this change and it was merged.
Change subject: Remove inexistent hook "LivePreviewPrepare"
......................................................................
Remove inexistent hook "LivePreviewPrepare"
This hook is never fired, therefore, per code review of
Ife952fc165dacea3ae7726e09bf61279f4bdae59 it should be
removed from CodeEditor.
Bug: 47235
Bug: 52071
Change-Id: Ic9dd9066f7d1676f45381cb6796425f13490fea3
---
M modules/jquery.codeEditor.js
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index f87acd7..6363476 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -174,9 +174,6 @@
// Bug 47235: Update text field for
LivePreview
if ( mw.hook ) {
- // New style hook
- mw.hook( 'LivePreviewPrepare'
).add( context.evt.codeEditorSubmit );
-
mw.hook( 'codeEditor.configure'
).fire( session );
}
// Old, deprecated style for backwards
compat
@@ -214,9 +211,6 @@
'disableCodeEditor': function () {
// Kills it!
context.$textarea.closest( 'form' ).unbind(
'submit', context.evt.codeEditorSubmit );
- if ( mw.hook ) {
- mw.hook( 'LivePreviewPrepare' ).remove(
context.evt.codeEditorSubmit );
- }
$( mw ).unbind( 'LivePreviewPrepare',
context.evt.codeEditorSubmit ); // deprecated
// Save contents
--
To view, visit https://gerrit.wikimedia.org/r/119527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9dd9066f7d1676f45381cb6796425f13490fea3
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Helder.wiki <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
