Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/119557
Change subject: QA: Increase timeouts for asynchronous steps ...................................................................... QA: Increase timeouts for asynchronous steps Waiting for a save to complete or for a page to reload and for the language button to re-appear can be slow. This increases the time allowed and should make these tests pass in the Chrome builds. See: https://saucelabs.com/jobs/4dbc507e29944d709f958c4584b33e52 Change-Id: I950d5d2e536ff28c5c27a779a65021f87e7d28f2 --- M tests/browser/features/editor_wikitext_saving.feature M tests/browser/features/step_definitions/common_article_steps.rb M tests/browser/features/step_definitions/editor_steps.rb M tests/browser/features/step_definitions/language_steps.rb 4 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/57/119557/1 diff --git a/tests/browser/features/editor_wikitext_saving.feature b/tests/browser/features/editor_wikitext_saving.feature index 03c0127..d827039 100644 --- a/tests/browser/features/editor_wikitext_saving.feature +++ b/tests/browser/features/editor_wikitext_saving.feature @@ -12,5 +12,6 @@ And I type "ABC GHI" into the editor And I click continue And I click submit - Then I see a toast notification + Then I should not see the wikitext editor + And I see a toast notification And I see the read in another language button diff --git a/tests/browser/features/step_definitions/common_article_steps.rb b/tests/browser/features/step_definitions/common_article_steps.rb index 3ab4333..a009048 100644 --- a/tests/browser/features/step_definitions/common_article_steps.rb +++ b/tests/browser/features/step_definitions/common_article_steps.rb @@ -20,7 +20,7 @@ Given(/^I click submit$/) do on(ArticlePage) do |page| - page.spinner_loading_element.when_not_present + page.spinner_loading_element.when_not_present(20) page.submit_button_element.when_present.click end end diff --git a/tests/browser/features/step_definitions/editor_steps.rb b/tests/browser/features/step_definitions/editor_steps.rb index 9544243..d9dec25 100644 --- a/tests/browser/features/step_definitions/editor_steps.rb +++ b/tests/browser/features/step_definitions/editor_steps.rb @@ -9,7 +9,7 @@ end Then(/^I see the wikitext editor$/) do - on(ArticlePage).editor_overlay_element.should be_visible + on(ArticlePage).editor_overlay_element.when_present.should be_visible end When(/^I click the wikitext editor overlay close button$/) do @@ -17,7 +17,8 @@ end Then(/^I should not see the wikitext editor$/) do - on(ArticlePage).editor_overlay_element.should_not be_visible + on(ArticlePage).spinner_loading_element.when_not_present(20) + on(ArticlePage).editor_overlay_element.when_not_present(20) end When(/^I clear the editor$/) do diff --git a/tests/browser/features/step_definitions/language_steps.rb b/tests/browser/features/step_definitions/language_steps.rb index 658ec0c..ed02403 100644 --- a/tests/browser/features/step_definitions/language_steps.rb +++ b/tests/browser/features/step_definitions/language_steps.rb @@ -1,5 +1,5 @@ When /^I see the read in another language button$/ do - on(ArticlePage).language_button_element.when_present.should be_visible + on(ArticlePage).language_button_element.when_present(10).should be_visible end When /^I click the language button$/ do -- To view, visit https://gerrit.wikimedia.org/r/119557 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I950d5d2e536ff28c5c27a779a65021f87e7d28f2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
