Addshore has submitted this change and it was merged.
Change subject: Remove unreachable code, "break" after thrown exception
......................................................................
Remove unreachable code, "break" after thrown exception
Change-Id: If8840128c056f6ad74fe7dff9ae9ac2adae91d41
---
M lib/includes/EntityFactory.php
M lib/includes/Term.php
M repo/includes/content/EntityHandler.php
3 files changed, 0 insertions(+), 3 deletions(-)
Approvals:
WikidataJenkins: Verified
Addshore: Looks good to me, approved
diff --git a/lib/includes/EntityFactory.php b/lib/includes/EntityFactory.php
index 6b2f5fa..f88c6f4 100644
--- a/lib/includes/EntityFactory.php
+++ b/lib/includes/EntityFactory.php
@@ -157,7 +157,6 @@
default:
throw new MWException( "serialization format
$format is not supported for '
. 'Wikibase content model" );
- break;
}
if ( $data === false || $data === null ) {
diff --git a/lib/includes/Term.php b/lib/includes/Term.php
index 970116b..e4b01a2 100644
--- a/lib/includes/Term.php
+++ b/lib/includes/Term.php
@@ -67,7 +67,6 @@
break;
default:
throw new MWException( 'Invalid term
field provided' );
- break;
}
}
}
diff --git a/repo/includes/content/EntityHandler.php
b/repo/includes/content/EntityHandler.php
index cc37837..f6c5787 100644
--- a/repo/includes/content/EntityHandler.php
+++ b/repo/includes/content/EntityHandler.php
@@ -153,7 +153,6 @@
default:
throw new MWException( "serialization format
$format is not supported "
. "for Wikibase content model" );
- break;
}
if ( $data === false || $data === null ) {
--
To view, visit https://gerrit.wikimedia.org/r/119715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8840128c056f6ad74fe7dff9ae9ac2adae91d41
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
