jenkins-bot has submitted this change and it was merged.
Change subject: Remove TestSites::insertIntoDb from Lua test setup helper
......................................................................
Remove TestSites::insertIntoDb from Lua test setup helper
It seems not needed, tests pass fine without and with
empty sites table
Having it in the helper causes unintended side-effect of the
contents of my actual sites table being replaced with
test contents. Then, I suppose during actual running of
tests, those are then using the unittest db which would have
no sites.
Change-Id: I289457cef38430e2c9f03efafb5c9b821a47fe5a
---
M
client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
WikidataJenkins: Verified
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php
b/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php
index 4f29a10..32ebd12 100644
---
a/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php
+++
b/client/tests/phpunit/includes/scribunto/WikibaseLuaIntegrationTestItemSetUpHelper.php
@@ -2,7 +2,6 @@
namespace Wikibase\Client\Scribunto\Test;
-use TestSites;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Claim\Statement;
@@ -47,7 +46,6 @@
return;
}
- TestSites::insertIntoDb();
$property = $this->createTestProperty();
$snak = $this->getTestSnak(
--
To view, visit https://gerrit.wikimedia.org/r/119075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I289457cef38430e2c9f03efafb5c9b821a47fe5a
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
