Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119745
Change subject: Make sure permissions aren't checked twice
......................................................................
Make sure permissions aren't checked twice
Change-Id: If3c26d75ec65c3243eceeec376453651377e06cb
---
M repo/includes/api/ApiWikibase.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/45/119745/1
diff --git a/repo/includes/api/ApiWikibase.php
b/repo/includes/api/ApiWikibase.php
index 7c553cd..0ef0cc5 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -255,6 +255,7 @@
*/
public function checkPermissions( Entity $entity, User $user, array
$params ) {
$permissions = $this->getRequiredPermissions( $entity, $params
);
+ $permissions = array_unique( $permissions );
$status = Status::newGood();
foreach ( $permissions as $perm ) {
--
To view, visit https://gerrit.wikimedia.org/r/119745
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3c26d75ec65c3243eceeec376453651377e06cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
