Alexandros Kosiaris has submitted this change and it was merged.

Change subject: lint admins.pp
......................................................................


lint admins.pp

replace all tab characters:
in vim:

 set tabstop=4
 set shiftwidth=4
 set expandtab

 :retab :wq

fix 795 x 'double quoted string containing no variables'

fix a couple hundred '=> on line isn't properly aligned'

1 x trailing whitespace

overall this reduces the number of lint warnings
from 4340 to 1263

this does not fix any warnings that can only be solved
by converting this to a module, like
"not in autoload module layout

it also does not fix "class defined inside a class",
"inherits across namespace" and "selector inside resource block"

Bug: 60277

Change-Id: Ieeaff1230ae8e6d6710dcc366da2f52e8d3dda8f
---
M manifests/admins.pp
1 file changed, 3,068 insertions(+), 3,077 deletions(-)

Approvals:
  Alexandros Kosiaris: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/118794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaff1230ae8e6d6710dcc366da2f52e8d3dda8f
Gerrit-PatchSet: 17
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: Matanya <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to