Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119772
Change subject: Followup for undefined index "bot", add bot param to MergeItems
......................................................................
Followup for undefined index "bot", add bot param to MergeItems
Follow up for Ie0650eb
MergeItems::getAllowedParams (and parent class methods) allow
setting a list of params with a default. "bot" was missing in
MergeItems, which extends ApiWikibase directly. Various other api
classes extend ModifyEntity or others that have "bot" set.
I believe that was the issue and this is a nicer, more consistent
way to fix the issue.
(still odd that the test failure happened only sometimes, though)
Change-Id: I16c8ea57618498bf22e603de1dd54b339d3a8f8a
(cherry picked from commit e7fe524832862bbb43157c514286905252223c88)
---
M repo/includes/api/MergeItems.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/119772/1
diff --git a/repo/includes/api/MergeItems.php b/repo/includes/api/MergeItems.php
index af5399e..6e9a588 100644
--- a/repo/includes/api/MergeItems.php
+++ b/repo/includes/api/MergeItems.php
@@ -212,6 +212,7 @@
ApiBase::PARAM_TYPE => 'string',
),
'token' => null,
+ 'bot' => false
)
);
}
@@ -232,6 +233,9 @@
autocomment together with the summary
is 260 characters. Be aware that everything above that
limit will be cut off."
),
+ 'bot' => array( 'Mark this edit as bot',
+ 'This URL flag will only be respected
if the user belongs to the group "bot".'
+ ),
)
);
}
--
To view, visit https://gerrit.wikimedia.org/r/119772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16c8ea57618498bf22e603de1dd54b339d3a8f8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.23-wmf19
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
