jenkins-bot has submitted this change and it was merged. Change subject: Added per-browser Cucumber tags ......................................................................
Added per-browser Cucumber tags Paired with Chris McMahon. Bug: 62846 Change-Id: I8758cb9819204c6b3771917683eb7b80f7ce1461 --- M tests/browser/features/create_account_failure_messages.feature M tests/browser/features/diff.feature M tests/browser/features/editor_ve.feature M tests/browser/features/editor_wikitext_nosave.feature M tests/browser/features/editor_wikitext_saving.feature M tests/browser/features/geonotahack.feature M tests/browser/features/keepgoing.feature M tests/browser/features/language.feature M tests/browser/features/language_logged_in.feature M tests/browser/features/login.feature M tests/browser/features/mainmenu.feature M tests/browser/features/nearby.feature M tests/browser/features/no_javascript_site.feature M tests/browser/features/notification.feature M tests/browser/features/page_loading.feature M tests/browser/features/pageactions.feature M tests/browser/features/pageactions_logged_in.feature M tests/browser/features/search.feature M tests/browser/features/search_special_page.feature M tests/browser/features/ui_links.feature M tests/browser/features/uploads_lead.feature M tests/browser/features/uploads_lead_tutorial.feature M tests/browser/features/uploads_page.feature M tests/browser/features/uploads_page_tutorial.feature M tests/browser/features/watchlist.feature 25 files changed, 24 insertions(+), 27 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/create_account_failure_messages.feature b/tests/browser/features/create_account_failure_messages.feature index 44b0e07..6babe86 100644 --- a/tests/browser/features/create_account_failure_messages.feature +++ b/tests/browser/features/create_account_failure_messages.feature @@ -1,4 +1,4 @@ [email protected] @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org Feature: Create failure messages Scenario: Can refresh captcha Given I am on the "Special:Userlogin" page diff --git a/tests/browser/features/diff.feature b/tests/browser/features/diff.feature index 547fbcf..e4bda9b 100644 --- a/tests/browser/features/diff.feature +++ b/tests/browser/features/diff.feature @@ -1,4 +1,4 @@ [email protected] @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: Page diff Scenario: Added and removed content diff --git a/tests/browser/features/editor_ve.feature b/tests/browser/features/editor_ve.feature index d1091c1..e92d358 100644 --- a/tests/browser/features/editor_ve.feature +++ b/tests/browser/features/editor_ve.feature @@ -1,4 +1,4 @@ [email protected] @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: VisualEditor Scenario: Toolbar VisualEditor diff --git a/tests/browser/features/editor_wikitext_nosave.feature b/tests/browser/features/editor_wikitext_nosave.feature index 9185c67..117cb17 100644 --- a/tests/browser/features/editor_wikitext_nosave.feature +++ b/tests/browser/features/editor_wikitext_nosave.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Wikitext Editor (TEST RUN ON WIKIPEDIA.ORG SO SHOULD NOT CAUSE SAVES) Background: diff --git a/tests/browser/features/editor_wikitext_saving.feature b/tests/browser/features/editor_wikitext_saving.feature index 03c0127..75d98b2 100644 --- a/tests/browser/features/editor_wikitext_saving.feature +++ b/tests/browser/features/editor_wikitext_saving.feature @@ -1,4 +1,4 @@ [email protected] @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: Wikitext Editor (Makes actual saves) Background: diff --git a/tests/browser/features/geonotahack.feature b/tests/browser/features/geonotahack.feature index d3b01a9..fcc2e24 100644 --- a/tests/browser/features/geonotahack.feature +++ b/tests/browser/features/geonotahack.feature @@ -1,4 +1,4 @@ [email protected] +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox Feature: Nearby pages Scenario: Nearby button visible diff --git a/tests/browser/features/keepgoing.feature b/tests/browser/features/keepgoing.feature index 29e6d74..727f16c 100644 --- a/tests/browser/features/keepgoing.feature +++ b/tests/browser/features/keepgoing.feature @@ -1,4 +1,4 @@ [email protected] +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox Feature: Encourage new users to Keep Going Scenario: I see a KeepGoing message after completing my edit diff --git a/tests/browser/features/language.feature b/tests/browser/features/language.feature index 0c0303f..c59fa22 100644 --- a/tests/browser/features/language.feature +++ b/tests/browser/features/language.feature @@ -1,5 +1,5 @@ # FIXME: this assumes that the main page has more than one language [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org Feature: Language selection Background: diff --git a/tests/browser/features/language_logged_in.feature b/tests/browser/features/language_logged_in.feature index fbc21e1..37eeef7 100644 --- a/tests/browser/features/language_logged_in.feature +++ b/tests/browser/features/language_logged_in.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Language Validation - Logged In Background: diff --git a/tests/browser/features/login.feature b/tests/browser/features/login.feature index 5d01c3e..8e6d8d4 100644 --- a/tests/browser/features/login.feature +++ b/tests/browser/features/login.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org Feature: Login Scenario: Not logged in diff --git a/tests/browser/features/mainmenu.feature b/tests/browser/features/mainmenu.feature index 58f79ff..f42ac90 100644 --- a/tests/browser/features/mainmenu.feature +++ b/tests/browser/features/mainmenu.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org Feature: Menus open correct page for anonymous users Background: diff --git a/tests/browser/features/nearby.feature b/tests/browser/features/nearby.feature index 3ea4afd..3ed59d4 100644 --- a/tests/browser/features/nearby.feature +++ b/tests/browser/features/nearby.feature @@ -1,4 +1,3 @@ -@chrome-bug @nearby_firefox Feature: Nearby page (mobile interface) Test currently only works with Firefox diff --git a/tests/browser/features/no_javascript_site.feature b/tests/browser/features/no_javascript_site.feature index fdcee28..ca08738 100644 --- a/tests/browser/features/no_javascript_site.feature +++ b/tests/browser/features/no_javascript_site.feature @@ -1,4 +1,4 @@ -@custom-browser @en.m.wikipedia.beta.wmflabs.org @test2.m.wikipedia.org +@custom-browser @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org Feature: Basic site for legacy devices # FIXME: Add scenario to check search actually works diff --git a/tests/browser/features/notification.feature b/tests/browser/features/notification.feature index 42627a3..ca0d42f 100644 --- a/tests/browser/features/notification.feature +++ b/tests/browser/features/notification.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Notification Background: diff --git a/tests/browser/features/page_loading.feature b/tests/browser/features/page_loading.feature index 860898c..252f9ab 100644 --- a/tests/browser/features/page_loading.feature +++ b/tests/browser/features/page_loading.feature @@ -1,4 +1,4 @@ [email protected] @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org Feature: Loading pages # In stable pages are loaded the standard way via links. diff --git a/tests/browser/features/pageactions.feature b/tests/browser/features/pageactions.feature index 503d496..4f0084a 100644 --- a/tests/browser/features/pageactions.feature +++ b/tests/browser/features/pageactions.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org Feature: Page actions menu when anonymous Background: diff --git a/tests/browser/features/pageactions_logged_in.feature b/tests/browser/features/pageactions_logged_in.feature index 565fe03..2b97474 100644 --- a/tests/browser/features/pageactions_logged_in.feature +++ b/tests/browser/features/pageactions_logged_in.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Page actions menu when logged in Background: diff --git a/tests/browser/features/search.feature b/tests/browser/features/search.feature index f14586a..0093bf4 100644 --- a/tests/browser/features/search.feature +++ b/tests/browser/features/search.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @test2.m.wikipedia.org Feature: Search Background: diff --git a/tests/browser/features/search_special_page.feature b/tests/browser/features/search_special_page.feature index 5b22d6c..8066a96 100644 --- a/tests/browser/features/search_special_page.feature +++ b/tests/browser/features/search_special_page.feature @@ -1,4 +1,4 @@ [email protected] @test2.m.wikipedia.org @en.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @test2.m.wikipedia.org @en.m.wikipedia.org Feature: Search Scenario: Search from Uploads diff --git a/tests/browser/features/ui_links.feature b/tests/browser/features/ui_links.feature index 1e9119a..088b34d 100644 --- a/tests/browser/features/ui_links.feature +++ b/tests/browser/features/ui_links.feature @@ -1,4 +1,4 @@ [email protected] +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox Feature: Check UI components Scenario: Check existence of important UI components on the main page diff --git a/tests/browser/features/uploads_lead.feature b/tests/browser/features/uploads_lead.feature index ebdb536..e1a23cb 100644 --- a/tests/browser/features/uploads_lead.feature +++ b/tests/browser/features/uploads_lead.feature @@ -1,4 +1,4 @@ [email protected] @test2.m.wikipedia.org @login +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: Lead image uploads Background: diff --git a/tests/browser/features/uploads_lead_tutorial.feature b/tests/browser/features/uploads_lead_tutorial.feature index 05959ef..b1d2556 100644 --- a/tests/browser/features/uploads_lead_tutorial.feature +++ b/tests/browser/features/uploads_lead_tutorial.feature @@ -1,4 +1,4 @@ [email protected] @test2.m.wikipedia.org @login +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: Lead image tutorial Background: diff --git a/tests/browser/features/uploads_page.feature b/tests/browser/features/uploads_page.feature index 3875b75..2b0a169 100644 --- a/tests/browser/features/uploads_page.feature +++ b/tests/browser/features/uploads_page.feature @@ -1,4 +1,4 @@ [email protected] @login @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @login @test2.m.wikipedia.org Feature: Special:Uploads uploads Scenario: Upload image file of invalid format diff --git a/tests/browser/features/uploads_page_tutorial.feature b/tests/browser/features/uploads_page_tutorial.feature index 72ce814..c53d18f 100644 --- a/tests/browser/features/uploads_page_tutorial.feature +++ b/tests/browser/features/uploads_page_tutorial.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org @login +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Special:Uploads tutorial Scenario: Link to tutorial for new user diff --git a/tests/browser/features/watchlist.feature b/tests/browser/features/watchlist.feature index 512c6dd..345e937 100644 --- a/tests/browser/features/watchlist.feature +++ b/tests/browser/features/watchlist.feature @@ -1,7 +1,6 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org +@chrome @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @firefox @login @test2.m.wikipedia.org Feature: Manage Watchlist - @login Scenario: Add an article to the watchlist Given I am logged into the mobile website And I am on the "Barack Obama" page @@ -10,7 +9,6 @@ And I see a toast with message "Added Barack Obama to your watchlist" And The watch star is selected - @login Scenario: Remove an article from the watchlist Given I am logged into the mobile website # FIXME: This assumes the scenario above has run and that the article is in fact watched -- To view, visit https://gerrit.wikimedia.org/r/119776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8758cb9819204c6b3771917683eb7b80f7ce1461 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
