Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119799
Change subject: Shut up warnings about calling cloneNode() with no parameters
......................................................................
Shut up warnings about calling cloneNode() with no parameters
The default value of the parameter is changing, so Firefox warns
when you call cloneNode() with no parameters. Instead, explicitly
call cloneNode( false ).
Change-Id: I817dff372727641c2ff2beda68f7327cb9a8ac19
---
M modules/ve/ve.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/99/119799/1
diff --git a/modules/ve/ve.js b/modules/ve/ve.js
index bccc9c1..bf323bf 100644
--- a/modules/ve/ve.js
+++ b/modules/ve/ve.js
@@ -756,7 +756,7 @@
// FIXME detaching breaks access to newDocument in IE
iframe.parentNode.removeChild( iframe );
- if ( !newDocument.documentElement ||
newDocument.documentElement.cloneNode() === undefined ) {
+ if ( !newDocument.documentElement ||
newDocument.documentElement.cloneNode( false ) === undefined ) {
// Surprise! The document is not a document! Only
happens on Opera.
// (Or its nodes are not actually nodes, while the
document
// *is* a document. This only happens when debugging
with Dragonfly.)
--
To view, visit https://gerrit.wikimedia.org/r/119799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I817dff372727641c2ff2beda68f7327cb9a8ac19
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
