jenkins-bot has submitted this change and it was merged. Change subject: QA: Fix Chrome builds for language browser tests ......................................................................
QA: Fix Chrome builds for language browser tests Prevent the search for an overlay from matching the LoadingOverlay by explicitly looking for the language overlay Change-Id: I63a93452858b899c182202135b3e20b363950503 --- M tests/browser/features/step_definitions/language_steps.rb M tests/browser/features/support/pages/article_page.rb 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Awjrichards: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/language_steps.rb b/tests/browser/features/step_definitions/language_steps.rb index 424e1b9..658ec0c 100644 --- a/tests/browser/features/step_definitions/language_steps.rb +++ b/tests/browser/features/step_definitions/language_steps.rb @@ -7,13 +7,13 @@ end Then(/^I see the language overlay$/) do - on(ArticlePage).overlay_element.when_present.class_name.should match "language-overlay" + on(ArticlePage).overlay_languages_element.when_present.class_name.should match "language-overlay" end When(/^I click the language overlay close button$/) do - on(ArticlePage).overlay_close_button_element.click + on(ArticlePage).overlay_languages_element.when_present.button_element(class: "cancel").click end Then(/^I don't see the languages overlay$/) do - on(ArticlePage).overlay_element.should_not be_visible + on(ArticlePage).overlay_languages_element.should_not be_visible end diff --git a/tests/browser/features/support/pages/article_page.rb b/tests/browser/features/support/pages/article_page.rb index 8f4eb2f..710e045 100644 --- a/tests/browser/features/support/pages/article_page.rb +++ b/tests/browser/features/support/pages/article_page.rb @@ -117,6 +117,8 @@ # secondary menu ## languages a(:language_button, css: ".languageSelector") + # Can't use generic overlay class as this will match with the LoadingOverlay that shows before loading the language overlay + div(:overlay_languages, css: ".language-overlay") #footer a(:desktop_link, text: "Desktop") -- To view, visit https://gerrit.wikimedia.org/r/119556 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63a93452858b899c182202135b3e20b363950503 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
