Niharika29 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119948
Change subject: Rename variables for better comprehension
......................................................................
Rename variables for better comprehension
Change-Id: Ifa8da084a93e85201564bae3aa71b0c3c899894b
---
M resources/js/ext.uls.compactlinks.js
1 file changed, 15 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/48/119948/1
diff --git a/resources/js/ext.uls.compactlinks.js
b/resources/js/ext.uls.compactlinks.js
index 27b0695..6e3b370 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -196,19 +196,27 @@
function manageInterlaguageList() {
var $numOfLangCurrently = $( '.interlanguage-link' ).length,
currentLangs = getInterlanguageList(),
- numLanguages = 9,
- minLanguages = 7,
+ longListLength = 9,
+ maxLanguageCheck = 12,
+ shortListLength = 7,
i,
- finalList; //Final list of languages to be displayed on
page
+ finalList; // Final list of languages to be displayed
on page
- if ( $numOfLangCurrently > 9) {
+ // If the total number of languages are between
9(longListLength) and 12(inclusive) then
+ // we show only 7 (shortListLength) languages (to avoid
displaying "2/3 more languages")
+ // Else, we show 9 languages. Please note that as per the
current design of the system, this
+ // does not always hold true. The language list might exceed 9.
This will be fixed as we refine
+ // the algo for the languages being shown.
+
+ if ( $numOfLangCurrently > longListLength ) {
hideLanguages();
- if ( $numOfLangCurrently > 9 && $numOfLangCurrently <=
12 ) {
- finalList = displayLanguages( minLanguages );
+ if ( $numOfLangCurrently > longListLength &&
$numOfLangCurrently <= maxLanguageCheck ) {
+ finalList = displayLanguages( shortListLength );
} else {
- finalList = displayLanguages( numLanguages );
+ finalList = displayLanguages( longListLength );
}
+ // Output all the languages we have in the finalList to
the page
for ( i in finalList ) {
addLanguage( $.uls.data.getAutonym(
finalList[i] ), currentLangs[ finalList[i] ] );
}
--
To view, visit https://gerrit.wikimedia.org/r/119948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa8da084a93e85201564bae3aa71b0c3c899894b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
