jenkins-bot has submitted this change and it was merged.
Change subject: Remove some unneeded local vars from EditPage.php
......................................................................
Remove some unneeded local vars from EditPage.php
Looks like a left over from refactoring in r31475
Change-Id: I6ffd2e1db8a842bebc37ce67e6265714258e79f9
---
M includes/EditPage.php
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Parent5446: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 5f5cb53..725ee10 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -3446,16 +3446,16 @@
}
$params = array(
- $image = $wgStylePath . '/common/images/' .
$tool['image'],
+ $wgStylePath . '/common/images/' .
$tool['image'],
// Note that we use the tip both for the ALT
tag and the TITLE tag of the image.
// Older browsers show a "speedtip" type
message only for ALT.
// Ideally these should be different,
realistically they
// probably don't need to be.
- $tip = $tool['tip'],
- $open = $tool['open'],
- $close = $tool['close'],
- $sample = $tool['sample'],
- $cssId = $tool['id'],
+ $tool['tip'],
+ $tool['open'],
+ $tool['close'],
+ $tool['sample'],
+ $tool['id'],
);
$script .= Xml::encodeJsCall( 'mw.toolbar.addButton',
$params );
--
To view, visit https://gerrit.wikimedia.org/r/119536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ffd2e1db8a842bebc37ce67e6265714258e79f9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: IAlex <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
