jenkins-bot has submitted this change and it was merged.

Change subject: Avoid JS deprecation notices
......................................................................


Avoid JS deprecation notices

Change-Id: I3aa12af75c019c367ccfb2d1ac9edce80e26869b
---
M resources/js/ext.translate.editor.helpers.js
1 file changed, 8 insertions(+), 9 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.translate.editor.helpers.js 
b/resources/js/ext.translate.editor.helpers.js
index 4e499cf..a82c27f 100644
--- a/resources/js/ext.translate.editor.helpers.js
+++ b/resources/js/ext.translate.editor.helpers.js
@@ -66,15 +66,14 @@
                                var $messageDesc = 
translateEditor.$editor.find( '.infocolumn-block .message-desc' );
 
                                if ( response.edit.result === 'Success' ) {
-                                       api.parse( newDocumentation,
-                                               function ( parsedDocumentation 
) {
-                                                       $messageDesc.html( 
parsedDocumentation );
-                                               },
-                                               function ( errorCode, results ) 
{
-                                                       $messageDesc.html( 
newDocumentation );
-                                                       mw.log( 'Error parsing 
documentation ' + errorCode + ' ' + results.error.info );
-                                               }
-                                       );
+                                       api.parse(
+                                               newDocumentation
+                                       ).done( function ( parsedDocumentation 
) {
+                                               $messageDesc.html( 
parsedDocumentation );
+                                       } ).fail( function ( errorCode, results 
) {
+                                               $messageDesc.html( 
newDocumentation );
+                                               mw.log( 'Error parsing 
documentation ' + errorCode + ' ' + results.error.info );
+                                       } );
                                        // A collapsible element may have been 
added
                                        $( '.mw-identical-title' 
).makeCollapsible();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/120208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3aa12af75c019c367ccfb2d1ac9edce80e26869b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to