Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/120331

Change subject: Declare visibility on class properties of SpecialUndelete
......................................................................

Declare visibility on class properties of SpecialUndelete

All class properties are used solely in the class itself. SpecialUndelete
is not being subclassed, so made all properties private.

Change-Id: I32792fb5d21178d850764c0efe3024d957fca2a8
---
M includes/specials/SpecialUndelete.php
1 file changed, 12 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/31/120331/1

diff --git a/includes/specials/SpecialUndelete.php 
b/includes/specials/SpecialUndelete.php
index e8a45a7..55ab32d 100644
--- a/includes/specials/SpecialUndelete.php
+++ b/includes/specials/SpecialUndelete.php
@@ -674,11 +674,20 @@
  * @ingroup SpecialPage
  */
 class SpecialUndelete extends SpecialPage {
-       var $mAction, $mTarget, $mTimestamp, $mRestore, $mInvert, $mFilename;
-       var $mTargetTimestamp, $mAllowed, $mCanView, $mComment, $mToken;
+       private $mAction;
+       private $mTarget;
+       private $mTimestamp;
+       private $mRestore;
+       private $mInvert;
+       private $mFilename;
+       private $mTargetTimestamp;
+       private $mAllowed;
+       private $mCanView;
+       private $mComment;
+       private $mToken;
 
        /** @var Title */
-       var $mTargetObj;
+       private $mTargetObj;
 
        function __construct() {
                parent::__construct( 'Undelete', 'deletedhistory' );

-- 
To view, visit https://gerrit.wikimedia.org/r/120331
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32792fb5d21178d850764c0efe3024d957fca2a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to