Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/120343

Change subject: Use escape key to hide popup
......................................................................

Use escape key to hide popup

Bug: 62948
Change-Id: I9623cd95b5e2832d68d9409d8056ad6d50da0398
---
M resources/ext.popups.core.js
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/43/120343/1

diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js
index bcac7e6..ee69e03 100644
--- a/resources/ext.popups.core.js
+++ b/resources/ext.popups.core.js
@@ -248,6 +248,12 @@
                        $el
                                .off( 'mouseleave blur', leaveInactive )
                                .on( 'mouseleave blur', leaveActive );
+
+                       $( document ).on( 'keydown', function( e ) { // Use 
escape to hide popup
+                               if ( e.keyCode === 27 ) {
+                                       closeBox();
+                               }
+                       } );
                }
 
                /**
@@ -300,6 +306,8 @@
                                clearTimeout( closeTimer );
                        }
 
+                       $( document ).off( 'keydown' );
+
                        logEvent();
                        currentLink = closeTimer = undefined;
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/120343
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9623cd95b5e2832d68d9409d8056ad6d50da0398
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to