jenkins-bot has submitted this change and it was merged.
Change subject: Fix language bar design
......................................................................
Fix language bar design
Language bar <table> form replaced by <divs>
Bug: 55386
Change-Id: I72927e8904a29f70f06419bc673799fc92e977a1
---
M resources/css/ext.translate.css
M tag/PageTranslationHooks.php
2 files changed, 11 insertions(+), 13 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/css/ext.translate.css b/resources/css/ext.translate.css
index a321463..dbadd11 100644
--- a/resources/css/ext.translate.css
+++ b/resources/css/ext.translate.css
@@ -4,26 +4,31 @@
direction: ltr;
}
-.mw-pt-languages table {
- direction: ltr;
+.mw-pt-languages {
+ display: table;
border: 1px solid rgb(170, 170, 170);
background: rgb(246, 249, 237) none repeat scroll 0 0;
border-collapse: collapse;
line-height: 1.2;
width: 100%;
clear: both;
+ overflow: auto;
}
.mw-pt-languages-label {
+ display: table-cell;
border-right: 1px solid rgb(170, 170, 170);
padding: 0.5em;
background: rgb(238, 243, 226) none repeat scroll 0 0;
- width: 200px;
font-weight: bold;
+ width: 15%;
}
.mw-pt-languages-list {
- padding: 0.5em;
+ padding-left: 0.5em;
+ padding-bottom: 0.7em;
+ display: table-cell;
+ width: 80%;
}
.mw-pt-translate-header {
diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index 425dba1..90daf92 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -315,20 +315,13 @@
'lang' => $userLangCode,
'dir' => $userLangDir
) );
- $out .= Html::openElement( 'table' );
- $out .= Html::openElement( 'tbody' );
- $out .= Html::openElement( 'tr', array( 'valign' => 'top' ) );
- $out .= Html::rawElement( 'td',
- array( 'class' => 'mw-pt-languages-label' ),
+ $out .= Html::rawElement( 'div', array( 'class' =>
'mw-pt-languages-label' ),
wfMessage( 'tpt-languages-legend' )->escaped()
);
- $out .= Html::rawElement( 'td',
+ $out .= Html::rawElement( 'div',
array( 'class' => 'mw-pt-languages-list autonym' ),
$languages
);
- $out .= Html::closeElement( 'tr' );
- $out .= Html::closeElement( 'tbody' );
- $out .= Html::closeElement( 'table' );
$out .= Html::closeElement( 'div' );
return $out;
--
To view, visit https://gerrit.wikimedia.org/r/120356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72927e8904a29f70f06419bc673799fc92e977a1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Kunalgrover05 <[email protected]>
Gerrit-Reviewer: Aklapper <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: SPQRobin <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
