TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/120472
Change subject: Convert from show()/hide() to using classes
......................................................................
Convert from show()/hide() to using classes
Follow-up to: Iadaae3fb9ae1899e12605d653b2688616b8f7c40
Change-Id: I4652ade66c6de864ee3e74b3817ed9b93967ce3d
---
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/72/120472/1
diff --git a/modules/jquery.wikiEditor.toolbar.css
b/modules/jquery.wikiEditor.toolbar.css
index 3551bca..a2f04fe 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -6,6 +6,11 @@
position: relative;
width: 100%;
}
+
+.wikiEditor-ui-toolbar .empty {
+ display:none;
+}
+
/* Expandable Sections */
.wikiEditor-ui-toolbar .sections {
float: left;
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index 884240a..88b1bde 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -61,6 +61,9 @@
// Tool
$group.append(
$.wikiEditor.modules.toolbar.fn.buildTool( context, tool, data[type][tool] ) );
}
+ if ( $group.children().length ) {
+ $group.removeClass( 'empty' );
+ }
smooth = false;
break;
case 'pages':
@@ -186,7 +189,7 @@
if ( group ) {
var $group =
context.modules.toolbar.$toolbar.find( group );
if ( $group.children().length === 0 ) {
- $group.hide();
+ $group.addClass( 'empty' );
}
}
}
@@ -295,7 +298,7 @@
}
}
if ( empty ) {
- $group.hide();
+ $group.addClass( 'empty' );
}
return $group;
},
--
To view, visit https://gerrit.wikimedia.org/r/120472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4652ade66c6de864ee3e74b3817ed9b93967ce3d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
