jenkins-bot has submitted this change and it was merged.
Change subject: Update MultimediaViewerNetworkPerformance schema rev.
......................................................................
Update MultimediaViewerNetworkPerformance schema rev.
Update schema to rev. 7917896, omitting the redundant 'userAgent' field, which
is already logged as part of the generic event capsule.
Change-Id: I558282ed29a14ba574204b4d5cba2a432449a75e
---
M MultimediaViewer.php
M resources/mmv/mmv.performance.js
M tests/qunit/mmv/mmv.performance.test.js
3 files changed, 2 insertions(+), 4 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 6cfee60..04395df 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -623,7 +623,7 @@
$wgResourceModules['schema.MultimediaViewerNetworkPerformance'] = array(
'class' => 'ResourceLoaderSchemaModule',
'schema' =>
'MultimediaViewerNetworkPerformance',
- 'revision' => 7488625,
+ 'revision' => 7917896,
);
$wgResourceModules['mmv.logger']['dependencies'][] =
'ext.eventLogging';
diff --git a/resources/mmv/mmv.performance.js b/resources/mmv/mmv.performance.js
index 6b67630..29bf2b5 100755
--- a/resources/mmv/mmv.performance.js
+++ b/resources/mmv/mmv.performance.js
@@ -101,7 +101,6 @@
var matches,
stats = { type: type,
contentHost: window.location.host,
- userAgent: navigator.userAgent,
isHttps: window.location.protocol === 'https:',
total: total },
connection = this.getNavigatorConnection();
diff --git a/tests/qunit/mmv/mmv.performance.test.js
b/tests/qunit/mmv/mmv.performance.test.js
index 5f5e27d..936e777 100644
--- a/tests/qunit/mmv/mmv.performance.test.js
+++ b/tests/qunit/mmv/mmv.performance.test.js
@@ -90,7 +90,7 @@
mw.eventLog = oldEventLog;
} );
- QUnit.test( 'recordEntry: with Navigation Timing data', 29, function (
assert ) {
+ QUnit.test( 'recordEntry: with Navigation Timing data', 28, function (
assert ) {
var fakeRequest,
varnish1 = 'cp1061',
varnish2 = 'cp3006',
@@ -210,7 +210,6 @@
assert.strictEqual( stats.response, response, 'response is
correct' );
assert.strictEqual( stats.cache, cache, 'cache is correct' );
assert.strictEqual( stats.country, country, 'country is
correct' );
- assert.strictEqual( stats.userAgent, navigator.userAgent,
'userAgent is correct' );
assert.strictEqual( stats.isHttps, true, 'isHttps is correct' );
assert.strictEqual( stats.status, status, 'status is correct' );
assert.strictEqual( stats.metered, metered, 'metered is
correct' );
--
To view, visit https://gerrit.wikimedia.org/r/120339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I558282ed29a14ba574204b4d5cba2a432449a75e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
