Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/120842
Change subject: Make generateCitationFeatures() not explode when citation code
isn't loaded
......................................................................
Make generateCitationFeatures() not explode when citation code isn't loaded
Bug: 63074
Change-Id: Ic3973d06707e89993bb551daba0fe13bd3cffc71
---
M modules/ve-mw/init/ve.init.mw.Target.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/42/120842/1
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index 7bff536..d3c0c6c 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -761,6 +761,11 @@
ve.init.mw.Target.prototype.generateCitationFeatures = function () {
var i, len, item, name, tool, tools, dialog;
+ if ( !ve.ui.MWCitationDialog ) {
+ // Citation module isn't loaded, so skip this
+ return;
+ }
+
/*jshint loopfunc:true */
try {
--
To view, visit https://gerrit.wikimedia.org/r/120842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3973d06707e89993bb551daba0fe13bd3cffc71
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
