Reedy has submitted this change and it was merged. Change subject: Begin transactions explicitely in Job class. ......................................................................
Begin transactions explicitely in Job class. This reverts commit dfbf524d3561e3fc54a9a072fda173435acc2e14 which was "Removed unmatched commits in Job class". The original change was reverted n the light of the recent discussion about the DBO_TRX flag and the intended use and bahavior of begin and commit. See http://www.gossamer-threads.com/lists/wiki/wikitech/300087 for Tim's explanation of DBO_TRX. This change now implements a new, alternative solution to the original problem of unmatched calls to commit: The Job class originally relied on implicitely started transactions. Introducing explicit calls to begin() avoids warnings while running tests, and causes transaxctiosn to be used also in cli (maintenance) mode. Change-Id: I6ecb8faad06449331a79b81860fe64624d3694d4 --- M includes/job/Job.php 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Reedy: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/25241 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ecb8faad06449331a79b81860fe64624d3694d4 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Platonides <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: Tim Starling <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
