Robmoen has submitted this change and it was merged. Change subject: Fixed ve.OrderedHashSet.filter ......................................................................
Fixed ve.OrderedHashSet.filter Was cloning the original set, then adding to it - resulting in always containing the whole set in any match. Also using test instead of exec since exec returns a string result, which under strange circumstances could return a falsy result, despite the RegExp finding a match. Change-Id: I09a7cb264521d58f02d6ff2547edad9a740b23b2 --- M modules/ve/ve.OrderedHashSet.js 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Robmoen: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25280 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09a7cb264521d58f02d6ff2547edad9a740b23b2 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Robmoen <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
