Bencmq has uploaded a new change for review.
https://gerrit.wikimedia.org/r/122116
Change subject: Clone thanked label before inserting
......................................................................
Clone thanked label before inserting
ThankedLabel is inserted before the Thank link that's being clicked.
The label needs to be cloned on each insertion so it is not removed
on subsequent $.insert().
Change-Id: I8327158880cba9a141a4d9977414022173c4c8ac
---
M modules/ext.thanks.flowthank.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks
refs/changes/16/122116/1
diff --git a/modules/ext.thanks.flowthank.js b/modules/ext.thanks.flowthank.js
index 74a7076..f9cbeda 100644
--- a/modules/ext.thanks.flowthank.js
+++ b/modules/ext.thanks.flowthank.js
@@ -12,7 +12,7 @@
$( 'a.mw-thanks-flow-thank-link' ).each( function( idx, el ) {
var $thankLink = $( el );
if ( mw.thanks.thanked.contains( $thankLink ) ) {
- $thankLink.before( $thankedLabel );
+ $thankLink.before( $thankedLabel.clone() );
$thankLink.remove();
}
} );
@@ -25,7 +25,7 @@
'token' : mw.user.tokens.get( 'editToken' )
} )
.done( function( data ) {
- $thankLink.before( $thankedLabel );
+ $thankLink.before( $thankedLabel.clone() );
$thankLink.remove();
mw.thanks.thanked.push( $thankLink );
} )
--
To view, visit https://gerrit.wikimedia.org/r/122116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8327158880cba9a141a4d9977414022173c4c8ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: Bencmq <bencmqw...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
