[MediaWiki-commits] [Gerrit] Fixed {{PLURAL...}} and other minor i18n things - change (mediawiki...NukeDPL)

[Luis Felipe Schenone (Code Review)]

Luis Felipe Schenone has submitted this change and it was merged.

Change subject: Fixed {{PLURAL...}} and other minor i18n things
......................................................................


Fixed {{PLURAL...}} and other minor i18n things

Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
---
M NukeDPL.i18n.php
M SpecialNukeDPL.php
2 files changed, 11 insertions(+), 8 deletions(-)

Approvals:
  Luis Felipe Schenone: Verified; Looks good to me, approved



diff --git a/NukeDPL.i18n.php b/NukeDPL.i18n.php
index 62a5361..3ed123b 100644
--- a/NukeDPL.i18n.php
+++ b/NukeDPL.i18n.php
@@ -17,12 +17,12 @@
 * Queries shouldn't be surrounded by any DPL tags or braces.
 * For information about the parameter meanings, see the 
[http://semeb.com/dpldemo/index.php?title=DPL:Manual DPL Manual].",
        'nukedpl-candidatelist' => 'View candidate list',
-       'nukedpl-nopages' => "No pages to delete using DPL-query: 
<code>$1</code>",
+       'nukedpl-nopages' => "No pages to delete using DPL query: 
<code>$1</code>",
        'nukedpl-nuke' => 'Nuke!',
-       'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL-query: <code>$1</code>
+       'nukedpl-list' => 'The following {{PLURAL:$1|page was|pages were}} 
selected by DPL query: <code>$2</code>
 
-Hit "{{int:nukedpl-nuke}}" to delete them.',
-       'nukedpl-defaultreason' => "Mass removal of pages selected by 
DPL-query: ($1)",
+Hit "{{int:nukedpl-nuke}}" to delete {{PLURAL:$1|it|them}}.',
+       'nukedpl-defaultreason' => "Mass removal of pages selected by DPL 
query: $1",
        'right-nukedpl' => 'Nuke pages by Dynamic Page List queries',
 );
 
@@ -51,6 +51,8 @@
        'nukedpl-candidatelist' => 'Anzeige der Löschkandidaten',
        'nukedpl-nopages' => "Keine Seiten zum Löschen bei folgendem DPL-Query: 
<code>$1</code>",
        'nukedpl-nuke' => 'Löschen!',
-       'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
<code>$1</code><br />Button drücken, um diese zu löschen.",
-       'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: ($1)",
+       'nukedpl-list' => "Die folgenden Seiten wurden gefunen. DPL-Query: 
<code>$2</code>
+
+Button drücken, um diese zu löschen.",
+       'nukedpl-defaultreason' => "Massenlöschung von Seiten mittels 
DPL-Query: $1",
 );
diff --git a/SpecialNukeDPL.php b/SpecialNukeDPL.php
index 292e3fb..900c96e 100644
--- a/SpecialNukeDPL.php
+++ b/SpecialNukeDPL.php
@@ -49,12 +49,13 @@
                $output = $this->getOutput();
 
                $pages = $this->getPages( $query );
-               if ( count( $pages ) == 0 ) {
+               $count = count( $pages );
+               if ( $count == 0 ) {
                        $output->addWikiText( $this->msg( 'nukedpl-nopages', 
$query )->text() );
                        return $this->queryForm();
                }
 
-               $output->addWikiText( $this->msg( 'nukedpl-list', $query 
)->text() );
+               $output->addWikiText( $this->msg( 'nukedpl-list', $count, 
$query )->text() );
 
                $output->addHTML( Xml::element( 'form', array( 'action' => 
$title->getLocalURL( 'action=delete' ), 'method' => 'post' ), null ) );
                $output->addHTML( Xml::element( 'input', array( 'type' => 
'submit', 'value' => $this->msg( 'nukedpl-nuke' )->text() ) ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/121958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6da6948b605c264e309a5d31bc1c5a3c14b3f27
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/NukeDPL
Gerrit-Branch: master
Gerrit-Owner: Luis Felipe Schenone <scheno...@gmail.com>
Gerrit-Reviewer: Luis Felipe Schenone <scheno...@gmail.com>
Gerrit-Reviewer: Raimond Spekking <raimond.spekk...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits