Mdale has submitted this change and it was merged.
Change subject: Fix starttime <= endtime comparision
......................................................................
Fix starttime <= endtime comparision
Using ">" operator on human formatted time strings (e.g. 10:15)
doesn't work very well.
Bug: 50336
Change-Id: Id857185b5a58026f239b315c7391722c3aaf8822
---
M TimedMediaHandler_body.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Mdale: Verified; Looks good to me, approved
diff --git a/TimedMediaHandler_body.php b/TimedMediaHandler_body.php
index e203ff9..0ef6eab 100644
--- a/TimedMediaHandler_body.php
+++ b/TimedMediaHandler_body.php
@@ -161,8 +161,9 @@
&& $params['start'] !== false
&& $params['end'] !== false
) {
- if($params['start'] > $params['end'])
+ if ( $this->parseTimeString( $params['start'] ) >
$this->parseTimeString( $params['end'] ) ) {
return false;
+ }
}
return true;
--
To view, visit https://gerrit.wikimedia.org/r/122273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id857185b5a58026f239b315c7391722c3aaf8822
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Mdale <md...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
