jenkins-bot has submitted this change and it was merged.
Change subject: Use wikibase.RepoApi in lib JavaScript
......................................................................
Use wikibase.RepoApi in lib JavaScript
Just to make sure this is really component independent (mw.Api only
queries the local api, while wikibase.RepoApi always queries the
api of the repo).
Change-Id: I88f0173f8a6fbc9385cb3c7f223f4e674460a190
---
M lib/resources/Resources.php
M lib/resources/formatters/wikibase.formatters.api.js
M lib/resources/parsers/wikibase.parsers.api.js
3 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
WikidataJenkins: Verified
Adrian Lang: Looks good to me, approved
Jeroen De Dauw: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 96b254b..1f90098 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -63,6 +63,7 @@
'parsers/wikibase.parsers.api.js',
),
'dependencies' => array(
+ 'wikibase.RepoApi',
'wikibase',
),
),
@@ -129,7 +130,7 @@
'formatters/wikibase.formatters.api.js',
),
'dependencies' => array(
- 'mediawiki.api',
+ 'wikibase.RepoApi',
'wikibase',
'wikibase.dataTypes'
),
diff --git a/lib/resources/formatters/wikibase.formatters.api.js
b/lib/resources/formatters/wikibase.formatters.api.js
index 4c3f497..04b9d57 100644
--- a/lib/resources/formatters/wikibase.formatters.api.js
+++ b/lib/resources/formatters/wikibase.formatters.api.js
@@ -2,12 +2,12 @@
* @licence GNU GPL v2+
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $, dataTypeStore ) {
+( function( wb, $, dataTypeStore ) {
'use strict';
wb.formatters = wb.formatters || {};
- var api = new mw.Api();
+ var api = new wb.RepoApi();
/**
* ValueFormatters API.
@@ -80,4 +80,4 @@
return deferred.promise();
};
-}( mediaWiki, wikibase, jQuery, wikibase.dataTypes ) );
+}( wikibase, jQuery, wikibase.dataTypes ) );
diff --git a/lib/resources/parsers/wikibase.parsers.api.js
b/lib/resources/parsers/wikibase.parsers.api.js
index cce87d7..63577ae 100644
--- a/lib/resources/parsers/wikibase.parsers.api.js
+++ b/lib/resources/parsers/wikibase.parsers.api.js
@@ -3,12 +3,12 @@
* @author Jeroen De Dauw < jeroended...@gmail.com >
* @author H. Snater < mediaw...@snater.com >
*/
-( function( mw, wb, $, dv ) {
+( function( wb, $, dv ) {
'use strict';
wb.parsers = wb.parsers || {};
- var api = new mw.Api();
+ var api = new wb.RepoApi();
/**
* ValueParsers API.
@@ -85,4 +85,4 @@
}
}
-}( mediaWiki, wikibase, jQuery, dataValues ) );
+}( wikibase, jQuery, dataValues ) );
--
To view, visit https://gerrit.wikimedia.org/r/120977
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88f0173f8a6fbc9385cb3c7f223f4e674460a190
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
