Pgehres has submitted this change and it was merged. Change subject: Minor updates to FundraiserUnsubscribe. ......................................................................
Minor updates to FundraiserUnsubscribe. Awight had proposed some changes to the last commit but I didn't get around to changing them before the whole thing got merged. So! - We now can control the syslog facility via config param, but by default it's set to LOG_USER - We can control if we want to log outbound XML. This removes a security concern whereby it logged the Silverpop password into the logs. - Fixed a silly IF condition in the Silverpop method. Change-Id: I987e4a0e00ecc18f64b9643a0c62a619e675b27c --- M FundraiserUnsubscribe.php M includes/Logger.php M includes/XmlTransactionProcessor.php M methods/FundraiserUnsubscribeSilverpop.php 4 files changed, 15 insertions(+), 5 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25471 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I987e4a0e00ecc18f64b9643a0c62a619e675b27c Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/DonationEmailUnsubscribe Gerrit-Branch: master Gerrit-Owner: Mwalker <mwal...@wikimedia.org> Gerrit-Reviewer: Adamw <awi...@wikimedia.org> Gerrit-Reviewer: Pgehres <pgeh...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
