Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/122656
Change subject: Add newline at the end of converted json files
......................................................................
Add newline at the end of converted json files
1) Some text editors add missing newline at the end of the file
automatically.
2) It's generally a nice thing to do to avoid messing up display
for example when cat'ing a file
Change-Id: Icf636721c4edcf4ae706c9a346fe36233928cae8
---
M maintenance/generateJsonI18n.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/56/122656/1
diff --git a/maintenance/generateJsonI18n.php b/maintenance/generateJsonI18n.php
index 27a9ff1..c485953 100644
--- a/maintenance/generateJsonI18n.php
+++ b/maintenance/generateJsonI18n.php
@@ -83,7 +83,7 @@
$jsonfile = "$jsondir/$langcode.json";
$success = file_put_contents(
$jsonfile,
- FormatJson::encode( $langmsgs, true,
FormatJson::ALL_OK )
+ FormatJson::encode( $langmsgs, true,
FormatJson::ALL_OK ) . "\n";
);
if ( $success === false ) {
$this->error( "FAILED to write $jsonfile", 1 );
--
To view, visit https://gerrit.wikimedia.org/r/122656
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf636721c4edcf4ae706c9a346fe36233928cae8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
