jenkins-bot has submitted this change and it was merged.
Change subject: Fix breakage on beta due to type hint being too strict
......................................................................
Fix breakage on beta due to type hint being too strict
Change-Id: I2ed0b80e61fed2dfca00095ff172a7f1d047250f
---
M MultimediaViewerHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MultimediaViewerHooks.php b/MultimediaViewerHooks.php
index 66fb7c1..0f6fe6c 100644
--- a/MultimediaViewerHooks.php
+++ b/MultimediaViewerHooks.php
@@ -228,9 +228,9 @@
* Modify thumbnail DOM
* @param ThumbnailImage $thumbnail
* @param array $attribs Attributes of the <img> element
- * @param array $linkAttribs Attributes of the wrapping <a> element
+ * @param array|boolean $linkAttribs Attributes of the wrapping <a>
element
*/
- public static function thumbnailBeforeProduceHTML( ThumbnailImage
$thumbnail, array &$attribs, array &$linkAttribs ) {
+ public static function thumbnailBeforeProduceHTML( ThumbnailImage
$thumbnail, array &$attribs, &$linkAttribs ) {
$file = $thumbnail->getFile();
if ( $file ) {
--
To view, visit https://gerrit.wikimedia.org/r/122713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ed0b80e61fed2dfca00095ff172a7f1d047250f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
