Physikerwelt has submitted this change and it was merged.
Change subject: Emit rerender on math node if Tex image is not present
......................................................................
Emit rerender on math node if Tex image is not present
This happens with then empty tag is rendered.
Bug: 63093
Change-Id: I5cf731cedda134d2542946da82997bddf58b00b5
---
M modules/VisualEditor/ve.ce.MWMathNode.js
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Physikerwelt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/VisualEditor/ve.ce.MWMathNode.js
b/modules/VisualEditor/ve.ce.MWMathNode.js
index d5dd2ed..54ee39d 100644
--- a/modules/VisualEditor/ve.ce.MWMathNode.js
+++ b/modules/VisualEditor/ve.ce.MWMathNode.js
@@ -48,7 +48,9 @@
};
/** */
-ve.ce.MWExtensionNode.prototype.afterRender = function ( domElements ) {
+ve.ce.MWMathNode.prototype.afterRender = function ( domElements ) {
+ var $img;
+
if ( this.$( domElements ).is( 'span.tex' ) ) {
// MathJax
MathJax.Hub.Queue(
@@ -56,10 +58,16 @@
[ this, this.emit, 'rerender' ]
);
} else {
+ $img = this.$element.find( 'img.tex' );
// Rerender after image load
- this.$element.find( 'img.tex' ).on( 'load', ve.bind( function
() {
+ if ( $img.length ) {
+ $img.on( 'load', ve.bind( function () {
+ this.emit( 'rerender' );
+ }, this ) );
+ } else {
+ // Passing an empty string returns no image, so
rerender immediately
this.emit( 'rerender' );
- }, this ) );
+ }
}
};
--
To view, visit https://gerrit.wikimedia.org/r/122602
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cf731cedda134d2542946da82997bddf58b00b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Math
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Physikerwelt <w...@physikerwelt.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
