John Erling Blad has submitted this change and it was merged. Change subject: Attempt to fix item lang+label+desc uniqueness restriction ......................................................................
Attempt to fix item lang+label+desc uniqueness restriction Do not merge without merging the follow up commit as well. This commit conatins broken state, but code I also want to keep in the history, as it represents a nicer solution then the follow up but is not possible due to bug in PHPs PDO, or at least in the SQLite implementation of PDO. Change-Id: Id1e2ec3e70b5b44d12e57da01198aa98fd7ef681 --- M repo/includes/content/ItemContent.php M repo/includes/store/sql/TermSqlCache.php M repo/tests/phpunit/includes/content/ItemContentTest.php M repo/tests/phpunit/includes/content/PropertyContentTest.php 4 files changed, 101 insertions(+), 15 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25284 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1e2ec3e70b5b44d12e57da01198aa98fd7ef681 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
