Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/123222
Change subject: Avoid fatal errors in Special:AdvancedTranslate due to core
json migration
......................................................................
Avoid fatal errors in Special:AdvancedTranslate due to core json migration
Renamed %CODE% to CODE to fool the checker.
Exception from line 4059 of /www/translatewiki.net/w/languages/Language.php:
Invalid language code "%CODE%"
*0 /www/translatewiki.net/w/languages/Language.php(4088):
Language::getFileName('/www/translatew...', '%CODE%', '.php')
*1
/www/translatewiki.net/w/extensions/Translate/ffs/MediaWikiComplexMessages.php(605):
Language::getMessagesFileName('%CODE%')
Change-Id: Ic1620c46c2003b01c4946bd82435fbd4b1f2ec09
---
M ffs/MediaWikiComplexMessages.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/22/123222/1
diff --git a/ffs/MediaWikiComplexMessages.php b/ffs/MediaWikiComplexMessages.php
index 3ec63df..a420930 100644
--- a/ffs/MediaWikiComplexMessages.php
+++ b/ffs/MediaWikiComplexMessages.php
@@ -218,7 +218,7 @@
protected function readVariable( $group, $code ) {
$file = $group['file'];
if ( !$group['code'] ) {
- $file = str_replace( '%CODE%', str_replace( '-', '_',
ucfirst( $code ) ), $file );
+ $file = str_replace( 'CODE', str_replace( '-', '_',
ucfirst( $code ) ), $file );
}
${$group['var']} = array(); # Initialize
@@ -602,7 +602,7 @@
$this->data['core'] = array(
'label' => 'MediaWiki Core',
'var' => 'specialPageAliases',
- 'file' => Language::getMessagesFileName( '%CODE%' ),
+ 'file' => Language::getMessagesFileName( 'CODE' ),
'code' => false,
);
@@ -683,7 +683,7 @@
$this->data['core'] = array(
'label' => 'MediaWiki Core',
'var' => 'magicWords',
- 'file' => Language::getMessagesFileName( '%CODE%' ),
+ 'file' => Language::getMessagesFileName( 'CODE' ),
'code' => false,
);
@@ -731,7 +731,7 @@
$this->data['core'] = array(
'label' => 'MediaWiki Core',
'var' => 'namespaceNames',
- 'file' => Language::getMessagesFileName( '%CODE%' ),
+ 'file' => Language::getMessagesFileName( 'CODE' ),
'code' => false,
);
}
--
To view, visit https://gerrit.wikimedia.org/r/123222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1620c46c2003b01c4946bd82435fbd4b1f2ec09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits