Nik has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/123227

Change subject: Added error handling to publishing changes.
......................................................................

Added error handling to publishing changes.

Change-Id: I2746fcce2545b96b33a1557353027e298ad824a8
---
M PublishChangesJob.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PubSubHubbub 
refs/changes/27/123227/1

diff --git a/PublishChangesJob.php b/PublishChangesJob.php
index 91e8f79..118df61 100644
--- a/PublishChangesJob.php
+++ b/PublishChangesJob.php
@@ -37,10 +37,11 @@
                global $wgPubSubHubbubHubURL;
                $publisher = new Publisher( $wgPubSubHubbubHubURL );
                if ( $publisher->publish_update( PubSubHubbub::getPageUrl( 
$this->title ) ) ) {
+                       wfDebug( "[PubSubHubbub] Publishing change succeeded." 
);
                        return true;
                } else {
-                       //TODO: Trigger some error.
                        $error = $publisher->last_response();
+                       wfDebug( "[PubSubHubbub] Error occured during publish: 
" . $error );
                        return false;
                }
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/123227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2746fcce2545b96b33a1557353027e298ad824a8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PubSubHubbub
Gerrit-Branch: master
Gerrit-Owner: Nik <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to