jenkins-bot has submitted this change and it was merged.
Change subject: Set font of the wb-firstHeading toolbar back to sans-serif
......................................................................
Set font of the wb-firstHeading toolbar back to sans-serif
I marked a few spots with FIXME. These lines can be removed
in 4 weeks when all caches got flushed.
Bug: 57436
Change-Id: I0865d144c70a726eb97b42a247d32131463bb6df
---
M lib/resources/wikibase.css
M repo/resources/themes/default/wikibase.toc.css
2 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
WikidataJenkins: Verified
Bartosz Dziewoński: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/resources/wikibase.css b/lib/resources/wikibase.css
index 6729754..8c3dda2 100644
--- a/lib/resources/wikibase.css
+++ b/lib/resources/wikibase.css
@@ -165,10 +165,14 @@
/********** LABEL **********/
+#content .wb-firstHeading {
+ font-size: 100%; /* required since Gerrit
Ic5ba836364d04b2c3814777b69b5f47fce25292a */
+}
+
.wb-firstHeading {
border-bottom: 0;
- margin-bottom: 0;
- padding-top: 0;
+ margin-bottom: 0; /* FIXME: Should be removed if the Typography refresh
is stable */
+ padding-top: 0; /* FIXME: Should be removed if the Typography refresh
is stable */
clear: both; /* so success bar after new item created won't float
heading */
}
@@ -212,6 +216,8 @@
/* the following lines are used to vertically position the toolbar on the
baseline of the heading
(label) which has a bigger font size */
.wb-firstHeading .wb-editsection {
+ /* FIXME: Should use the LESS variable @content-font-family */
+ font-family: Arimo, "Liberation Sans", "Helvetica Neue", Helvetica,
Arial, sans-serif;
line-height: 188%;
top: .3em; /* even out margin of label container in view mode */
}
@@ -228,11 +234,6 @@
.wb-firstHeading .wikibase-toolbar .wikibase-toolbarlabel /* tooltip */ {
font-size: 100%;
margin-bottom: 0; /* even out border of label container in view mode */
-}
-
-/* FIXME: Very specific selector to temporary overrule VectorBeta extension */
-#content .wb-firstHeading {
- font-size: 100%;
}
/********** /LABEL **********/
diff --git a/repo/resources/themes/default/wikibase.toc.css
b/repo/resources/themes/default/wikibase.toc.css
index b3e1bf5..c6e0b6f 100644
--- a/repo/resources/themes/default/wikibase.toc.css
+++ b/repo/resources/themes/default/wikibase.toc.css
@@ -37,7 +37,7 @@
border-right: 0;
}
-/* FIXME: Very specific selector to temporary overrule VectorBeta extension */
+/* FIXME: Should be removed if the Typography refresh is stable */
#content .wb-entity #toc {
margin-top: 1.8em;
}
--
To view, visit https://gerrit.wikimedia.org/r/123203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0865d144c70a726eb97b42a247d32131463bb6df
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits