jenkins-bot has submitted this change and it was merged.
Change subject: Fix capitalization and tests of $this->mId.
......................................................................
Fix capitalization and tests of $this->mId.
Property name is $mID, certain parts were testing $mId, and then
using isset to (presumably) hide the undefined property warnings.
Change-Id: I0c2d29fbdb8314aa0c04bea387364a7307e68b9b
---
M InputBox.classes.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/InputBox.classes.php b/InputBox.classes.php
index b3fdd0c..5103565 100644
--- a/InputBox.classes.php
+++ b/InputBox.classes.php
@@ -331,8 +331,8 @@
'action' => $wgScript,
'method' => 'get'
);
- if( isset( $this->mId ) ) {
- $createBoxParams['id'] = Sanitizer::escapeId(
$this->mId );
+ if( $this->mID !== '' ) {
+ $createBoxParams['id'] = Sanitizer::escapeId(
$this->mID );
}
$htmlOut .= Xml::openElement( 'form', $createBoxParams );
$htmlOut .= Xml::openElement( 'input',
@@ -441,8 +441,8 @@
'action' => $wgScript,
'method' => 'get'
);
- if( isset( $this->mId ) ) {
- $commentFormParams['id'] = Sanitizer::escapeId(
$this->mId );
+ if( $this->mID !== '' ) {
+ $commentFormParams['id'] = Sanitizer::escapeId(
$this->mID );
}
$htmlOut .= Xml::openElement( 'form', $commentFormParams );
$htmlOut .= Xml::openElement( 'input',
--
To view, visit https://gerrit.wikimedia.org/r/124132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c2d29fbdb8314aa0c04bea387364a7307e68b9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/InputBox
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
