jenkins-bot has submitted this change and it was merged.
Change subject: Fix [missing] variables in @param docs
......................................................................
Fix [missing] variables in @param docs
Two places found without variable, one without $ and one only missed a
space before $
Change-Id: Iacd7c386d57223f3a112b59cd11383ef5c0ac2f1
---
M includes/Title.php
M includes/media/GIF.php
M includes/poolcounter/PoolCounterRedis.php
M includes/site/SiteSQLStore.php
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Title.php b/includes/Title.php
index 995deeb..d025f35 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -4916,7 +4916,7 @@
* they will already be wrapped in paragraphs.
*
* @since 1.21
- * @param int oldid Revision ID that's being edited
+ * @param int $oldid Revision ID that's being edited
* @return Array
*/
public function getEditNotices( $oldid = 0 ) {
diff --git a/includes/media/GIF.php b/includes/media/GIF.php
index bde889c..5992be1 100644
--- a/includes/media/GIF.php
+++ b/includes/media/GIF.php
@@ -78,7 +78,7 @@
/**
* @todo Add unit tests
*
- * @param File$image
+ * @param File $image
* @return bool
*/
function getImageArea( $image ) {
diff --git a/includes/poolcounter/PoolCounterRedis.php
b/includes/poolcounter/PoolCounterRedis.php
index 1bc10f2..5c88239 100644
--- a/includes/poolcounter/PoolCounterRedis.php
+++ b/includes/poolcounter/PoolCounterRedis.php
@@ -267,7 +267,7 @@
/**
* @param RedisConnRef $conn
- * @param float UNIX timestamp
+ * @param float $now UNIX timestamp
* @return string|bool False on failure
*/
protected function initAndPopPoolSlotList( RedisConnRef $conn, $now ) {
diff --git a/includes/site/SiteSQLStore.php b/includes/site/SiteSQLStore.php
index 11141e0..7bf933c 100644
--- a/includes/site/SiteSQLStore.php
+++ b/includes/site/SiteSQLStore.php
@@ -193,7 +193,7 @@
*
* @since 1.22
*
- * @param Site
+ * @param Site $site
*
* @return ORMRow
*/
--
To view, visit https://gerrit.wikimedia.org/r/124168
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iacd7c386d57223f3a112b59cd11383ef5c0ac2f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
