jenkins-bot has submitted this change and it was merged.
Change subject: Fix infinite spinner in JS version of show changes
......................................................................
Fix infinite spinner in JS version of show changes
Empty content causes the hiding of the spinner to be skipped.
Bug: 38502
Change-Id: Iefb224877976d463a5bb7b92a8e09fe958cd16c2
---
M modules/jquery.wikiEditor.preview.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.preview.js
b/modules/jquery.wikiEditor.preview.js
index 372d2e8..0c209b8 100644
--- a/modules/jquery.wikiEditor.preview.js
+++ b/modules/jquery.wikiEditor.preview.js
@@ -127,10 +127,10 @@
.revisions[0].diff['*'];
context.$changesTab.find( 'table.diff tbody' )
.html( diff );
-
context.$changesTab
-
.find( '.wikiEditor-preview-loading' ).hide();
context.modules.preview.changesText = wikitext;
} catch ( e ) {
} // "blah is undefined" error, ignore
+
context.$changesTab
+ .find(
'.wikiEditor-preview-loading' ).hide();
}, 'json'
);
} catch ( e ) { } // "blah is
undefined" error, ignore
--
To view, visit https://gerrit.wikimedia.org/r/124352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefb224877976d463a5bb7b92a8e09fe958cd16c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
