jenkins-bot has submitted this change and it was merged.

Change subject: Search: Prevent unneeded API request when there aren't any 
titles
......................................................................


Search: Prevent unneeded API request when there aren't any titles

Watchlist stars no longer searches for [undefined, undefined, undefined],
caused by looking at other <ul>s that happen to be in the search section.

Bug: 63317
Change-Id: I2a09523ba1128747b477ec4a0c16a3183bdd022b
---
M javascripts/modules/mf-watchstar.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/javascripts/modules/mf-watchstar.js 
b/javascripts/modules/mf-watchstar.js
index 28797f5..2693344 100644
--- a/javascripts/modules/mf-watchstar.js
+++ b/javascripts/modules/mf-watchstar.js
@@ -218,7 +218,7 @@
 
        function upgradeUI() {
                M.on( 'search-results', function( overlay ) {
-                       initWatchListIconList( overlay.$( 'ul' ) );
+                       initWatchListIconList( overlay.$( 'ul.page-list' ) );
                } );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/124281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a09523ba1128747b477ec4a0c16a3183bdd022b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Theopolisme <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Theopolisme <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to