Katie Horn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/124367

Change subject: Sending the STOMP message if there's a chance we've been 
successful.
......................................................................

Sending the STOMP message if there's a chance we've been
successful.

This commit mostly exists to illustrate that this is not an ideal
situation, with all the returns that might short-curcuit the
message being sent.

Change-Id: I0d645387d16ee23754f20fe0960c023b432710e1
---
M worldpay_gateway/worldpay.adapter.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/67/124367/1

diff --git a/worldpay_gateway/worldpay.adapter.php 
b/worldpay_gateway/worldpay.adapter.php
index c73b372..dc14ef7 100644
--- a/worldpay_gateway/worldpay.adapter.php
+++ b/worldpay_gateway/worldpay.adapter.php
@@ -672,6 +672,8 @@
                                                        "Finalizing transaction 
at AuthorizePaymentForFraud to {$result_status}. Code: {$code}"
                                                );
                                                $this->finalizeInternalStatus( 
$result_status );
+                                               //final stomp message sending 
is in RunPostProcessHooks()... and this is the only place we have final status 
right now.
+                                               $this->runPostProcessHooks();
                                                return $result;
                                        }
                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/124367
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d645387d16ee23754f20fe0960c023b432710e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to