Wctaiwan has uploaded a new change for review.
https://gerrit.wikimedia.org/r/124383
Change subject: HTMLForm vform styling
......................................................................
HTMLForm vform styling
Style <select> like other input fields (full width), and fix the issue
where validation errors partially obfuscate the fields by setting display:
block.
Bug: 63644
Change-Id: I00a35c932a7e0b91b7b01fc327c0c1b9bae66c78
---
M resources/mediawiki.ui/components/default/forms.less
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/83/124383/1
diff --git a/resources/mediawiki.ui/components/default/forms.less
b/resources/mediawiki.ui/components/default/forms.less
index 6157fa2..1456816 100644
--- a/resources/mediawiki.ui/components/default/forms.less
+++ b/resources/mediawiki.ui/components/default/forms.less
@@ -50,6 +50,7 @@
// MW currently doesn't use the type attribute everywhere on inputs.
input,
+ select,
.mw-ui-button {
display: block;
.box-sizing(border-box);
@@ -59,7 +60,8 @@
// We exclude these because they'll generally use mw-ui-button.
// Otherwise, we'll unintentionally override that.
- input:not([type=button]):not([type=submit]):not([type=file]), {
+ input:not([type=button]):not([type=submit]):not([type=file]),
+ select {
.agora-field-styling(); // mixins/forms.less
}
@@ -103,8 +105,9 @@
// Styleguide 3.1.
.error {
.box-sizing(border-box);
+ display: block;
font-size: 0.9em;
- margin: 0 0 1em;
+ margin: 0.5em 0 1em 0;
padding: 0.5em;
color: #cc0000;
border: 1px solid #fac5c5;
--
To view, visit https://gerrit.wikimedia.org/r/124383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00a35c932a7e0b91b7b01fc327c0c1b9bae66c78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Wctaiwan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
