Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/124395
Change subject: webperf: couple lint issues in python scripts
......................................................................
webperf: couple lint issues in python scripts
navtiming.py raise an ArgumentError which comes from the argparse
module. Fully qualify it.
ve.py imported logging without ever using it
Change-Id: I1dd3109fe53e5c5d263af7f2ef16b1d440af1d85
---
M modules/webperf/files/navtiming.py
M modules/webperf/files/ve.py
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/95/124395/1
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index b8e8656..87522c0 100644
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -43,7 +43,7 @@
def dispatch_stat(*args):
if len(args) < 2:
- raise ArgumentError
+ raise argparse.ArgumentError
args = list(args)
value = args.pop()
name = '.'.join([prefix] + args)
diff --git a/modules/webperf/files/ve.py b/modules/webperf/files/ve.py
index eb70357..dd6a1c5 100644
--- a/modules/webperf/files/ve.py
+++ b/modules/webperf/files/ve.py
@@ -6,7 +6,6 @@
sys.setdefaultencoding("utf-8")
import argparse
-import logging
import socket
import zmq
--
To view, visit https://gerrit.wikimedia.org/r/124395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dd3109fe53e5c5d263af7f2ef16b1d440af1d85
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
