jenkins-bot has submitted this change and it was merged.
Change subject: Regression: Clicking hamburger 2nd time closes menu
......................................................................
Regression: Clicking hamburger 2nd time closes menu
This was broken by the introduction of the navigation drawer
Change-Id: Ib2860b2b45affb105aba590025bdd64ace6b3328
---
M javascripts/common/mainmenu.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/common/mainmenu.js b/javascripts/common/mainmenu.js
index 76f139d..ac534d0 100644
--- a/javascripts/common/mainmenu.js
+++ b/javascripts/common/mainmenu.js
@@ -53,7 +53,11 @@
} );
} else {
$( '#mw-mf-main-menu-button' ).click( function( ev ) {
- openNavigationDrawer();
+ if ( isOpen() ) {
+ closeNavigationDrawers();
+ } else {
+ openNavigationDrawer();
+ }
ev.preventDefault();
} ).on( 'touchend mouseup', function( ev ) {
ev.stopPropagation();
--
To view, visit https://gerrit.wikimedia.org/r/124472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2860b2b45affb105aba590025bdd64ace6b3328
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
