Adamw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/124499
Change subject: Bugfix: we would fail if the xml was compact
......................................................................
Bugfix: we would fail if the xml was compact
Change-Id: Ib92c5501156c631cf8694337e17498a39adc549b
---
M gateway_common/gateway.adapter.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/99/124499/1
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index aa5a5cc..8be2202 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -1425,12 +1425,12 @@
function stripXMLResponseHeaders( $rawResponse ) {
$xmlStart = strpos( $rawResponse, '<?xml' );
- if ( $xmlStart == false ) {
+ if ( $xmlStart === false ) {
//I totally saw this happen one time. No XML, just
<RESPONSE>...
//...Weaken to almost no error checking. Buckle up!
$xmlStart = strpos( $rawResponse, '<' );
}
- if ( $xmlStart == false ) { //Still false. Your Head Asplode.
+ if ( $xmlStart === false ) { //Still false. Your Head Asplode.
$this->log( "Completely Mangled Response:\n" .
$rawResponse, LOG_ERR );
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/124499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib92c5501156c631cf8694337e17498a39adc549b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
