jenkins-bot has submitted this change and it was merged.
Change subject: Fix tipsy bug
......................................................................
Fix tipsy bug
maybeDisplayThumbnail is invoked even when the survey is disabled,
which results in calling functions of a null object.
Change-Id: If7a48349e22069f91af20d8c4bb6a82b7339bd66
---
M resources/mmv/ui/mmv.ui.stripeButtons.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Aarcos: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js
b/resources/mmv/ui/mmv.ui.stripeButtons.js
index 756aa0f..d2af403 100644
--- a/resources/mmv/ui/mmv.ui.stripeButtons.js
+++ b/resources/mmv/ui/mmv.ui.stripeButtons.js
@@ -271,7 +271,9 @@
this.setDescriptionPageButton( imageInfo, repoInfo );
}
- this.maybeDisplayTooltip();
+ if ( this.shouldShowFeedbackSurvey() ) {
+ this.maybeDisplayTooltip();
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/125056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7a48349e22069f91af20d8c4bb6a82b7339bd66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Aarcos <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
