Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/125170
Change subject: Cleanup some Ruby code
......................................................................
Cleanup some Ruby code
Change-Id: I137483e68c068f97883d84de88636f7bb897ca78
---
M tests/browser/features/step_definitions/special_modify_entity_steps.rb
M tests/browser/features/step_definitions/special_modify_term_steps.rb
M tests/browser/features/support/pages/special_modify_entity_page.rb
M tests/browser/features/support/pages/special_modify_term_page.rb
4 files changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/70/125170/1
diff --git
a/tests/browser/features/step_definitions/special_modify_entity_steps.rb
b/tests/browser/features/step_definitions/special_modify_entity_steps.rb
index feca3d2..6e30f8f 100644
--- a/tests/browser/features/step_definitions/special_modify_entity_steps.rb
+++ b/tests/browser/features/step_definitions/special_modify_entity_steps.rb
@@ -11,8 +11,8 @@
on(SpecialModifyEntityPage).id_input_field = value
end
-When /^I enter the ID of item (.*) into the ID input field$/ do |item_handle|
- step "I enter " + @items[item_handle]['id'] + " in the ID input field"
+When /^I enter the ID of item (.+) into the ID input field$/ do |item_handle|
+ step "I enter " + @items[item_handle]["id"] + " in the ID input field"
end
Then /^Anonymous edit warning should be there$/ do
diff --git
a/tests/browser/features/step_definitions/special_modify_term_steps.rb
b/tests/browser/features/step_definitions/special_modify_term_steps.rb
index 59ea941..fd154b1 100644
--- a/tests/browser/features/step_definitions/special_modify_term_steps.rb
+++ b/tests/browser/features/step_definitions/special_modify_term_steps.rb
@@ -11,6 +11,6 @@
on(SpecialModifyTermPage).language_input_field?.should be_true
end
-When /^I enter (.*) into the language input field$/ do |language_code|
+When /^I enter (.+) into the language input field$/ do |language_code|
on(SpecialModifyTermPage).language_input_field = language_code
end
diff --git a/tests/browser/features/support/pages/special_modify_entity_page.rb
b/tests/browser/features/support/pages/special_modify_entity_page.rb
index 1bb6dc7..7fe4dd2 100644
--- a/tests/browser/features/support/pages/special_modify_entity_page.rb
+++ b/tests/browser/features/support/pages/special_modify_entity_page.rb
@@ -9,10 +9,8 @@
class SpecialModifyEntityPage
include PageObject
- page_url URL.repo_url("Special:ModifyEntity")
-
- p(:anonymous_edit_warning, :class => 'warning')
- p(:error_message, :class => 'error')
- text_field(:id_input_field, :id => 'wb-modifyentity-id')
+ p(:anonymous_edit_warning, class: "warning")
+ p(:error_message, class: "error")
+ text_field(:id_input_field, id: "wb-modifyentity-id")
end
diff --git a/tests/browser/features/support/pages/special_modify_term_page.rb
b/tests/browser/features/support/pages/special_modify_term_page.rb
index f973ee2..2157456 100644
--- a/tests/browser/features/support/pages/special_modify_term_page.rb
+++ b/tests/browser/features/support/pages/special_modify_term_page.rb
@@ -9,9 +9,7 @@
class SpecialModifyTermPage < SpecialModifyEntityPage
include PageObject
- page_url URL.repo_url("Special:ModifyTerm")
-
- text_field(:language_input_field, :id => 'wb-modifyterm-language')
- text_field(:term_input_field, :id => 'wb-modifyterm-value')
+ text_field(:language_input_field, id: "wb-modifyterm-language")
+ text_field(:term_input_field, id: "wb-modifyterm-value")
end
--
To view, visit https://gerrit.wikimedia.org/r/125170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I137483e68c068f97883d84de88636f7bb897ca78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
