Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/125172
Change subject: (WIP) Converted Ruby pageObjects to modules
......................................................................
(WIP) Converted Ruby pageObjects to modules
Change-Id: Ifffb996b8041527c4f65986a119aebb0e2d77871
---
R tests/browser/features/support/modules/special_modify_entity_page.rb
R tests/browser/features/support/modules/special_modify_term_page.rb
M tests/browser/features/support/pages/special_set_label_page.rb
3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/125172/1
diff --git a/tests/browser/features/support/pages/special_modify_entity_page.rb
b/tests/browser/features/support/modules/special_modify_entity_page.rb
similarity index 91%
rename from tests/browser/features/support/pages/special_modify_entity_page.rb
rename to tests/browser/features/support/modules/special_modify_entity_page.rb
index 7fe4dd2..46f9889 100644
--- a/tests/browser/features/support/pages/special_modify_entity_page.rb
+++ b/tests/browser/features/support/modules/special_modify_entity_page.rb
@@ -6,7 +6,7 @@
#
# page object for the Special:ModifyEntity page
-class SpecialModifyEntityPage
+module SpecialModifyEntityPage
include PageObject
p(:anonymous_edit_warning, class: "warning")
diff --git a/tests/browser/features/support/pages/special_modify_term_page.rb
b/tests/browser/features/support/modules/special_modify_term_page.rb
similarity index 83%
rename from tests/browser/features/support/pages/special_modify_term_page.rb
rename to tests/browser/features/support/modules/special_modify_term_page.rb
index 2157456..318817d 100644
--- a/tests/browser/features/support/pages/special_modify_term_page.rb
+++ b/tests/browser/features/support/modules/special_modify_term_page.rb
@@ -6,8 +6,9 @@
#
# page object for the Special:ModifyTerm page
-class SpecialModifyTermPage < SpecialModifyEntityPage
+module SpecialModifyTermPage
include PageObject
+ include SpecialModifyEntityPage
text_field(:language_input_field, id: "wb-modifyterm-language")
text_field(:term_input_field, id: "wb-modifyterm-value")
diff --git a/tests/browser/features/support/pages/special_set_label_page.rb
b/tests/browser/features/support/pages/special_set_label_page.rb
index 9816498..c86c271 100644
--- a/tests/browser/features/support/pages/special_set_label_page.rb
+++ b/tests/browser/features/support/pages/special_set_label_page.rb
@@ -6,8 +6,9 @@
#
# page object for the Special:SetLabel page
-class SpecialSetLabelPage < SpecialModifyTermPage
+class SpecialSetLabelPage
include PageObject
+ include SpecialModifyTermPage
page_url URL.repo_url("Special:SetLabel")
--
To view, visit https://gerrit.wikimedia.org/r/125172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifffb996b8041527c4f65986a119aebb0e2d77871
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
