EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/125934

Change subject: Dont pass objects through the api query
......................................................................

Dont pass objects through the api query

Change-Id: Ibff6faf74a01a7161b392fd98f4bc8e693d1f929
---
M tests/ApiFlowThankIntegrationTest.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Thanks 
refs/changes/34/125934/1

diff --git a/tests/ApiFlowThankIntegrationTest.php 
b/tests/ApiFlowThankIntegrationTest.php
index 1f7a0d9..2731928 100644
--- a/tests/ApiFlowThankIntegrationTest.php
+++ b/tests/ApiFlowThankIntegrationTest.php
@@ -109,7 +109,7 @@
                $this->setExpectedException( 'UsageException', 'The token 
parameter must be set' );
                $this->doApiRequest( array(
                        'action' => 'flowthank',
-                       'postid' => UUID::create( '42' ),
+                       'postid' => UUID::create( '42' )->getAlphadecimal(),
                ) );
        }
 
@@ -121,7 +121,7 @@
        public function testValidRequest(){
                list( $result,, ) = $this->doApiRequestWithToken( array(
                        'action' => 'flowthank',
-                       'postid' => $this->postByOtherUser->getPostId(),
+                       'postid' => 
$this->postByOtherUser->getPostId()->getAlphadecimal(),
                ) );
                $this->assertSuccess( $result );
        }
@@ -130,7 +130,7 @@
                $this->setExpectedException( 'UsageException', 'Post ID is 
invalid' );
                list( $result,, ) = $this->doApiRequestWithToken( array(
                        'action' => 'flowthank',
-                       'postid' => UUID::create( '42' ),
+                       'postid' => UUID::create( '42' )->getAlphadecimal(),
                ) );
        }
 
@@ -138,7 +138,7 @@
                $this->setExpectedException( 'UsageException', 'You cannot 
thank yourself' );
                list( $result,, ) = $this->doApiRequestWithToken( array(
                        'action' => 'flowthank',
-                       'postid' => $this->postByMe->getPostId(),
+                       'postid' => 
$this->postByMe->getPostId()->getAlphadecimal(),
                ) );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/125934
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibff6faf74a01a7161b392fd98f4bc8e693d1f929
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Thanks
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to