Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/125953

Change subject: TopicBlock: fix renerTopicAPI to output history if requested
......................................................................

TopicBlock: fix renerTopicAPI to output history if requested

Probably just a typo, adding to $options does absolutely nothing

Change-Id: I4becd64221ca7abbcaf6a73b0dbcdcb21bc83695
---
M includes/Block/Topic.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/53/125953/1

diff --git a/includes/Block/Topic.php b/includes/Block/Topic.php
index 6d4bb29..7d6cc99 100644
--- a/includes/Block/Topic.php
+++ b/includes/Block/Topic.php
@@ -596,7 +596,7 @@
                );
 
                if ( isset( $options['showhistoryfor'] ) ) {
-                       $options['history'] = array();
+                       $output['history'] = array();
 
                        $historyBatch = $this->getHistoryBatch( 
(array)$options['showhistoryfor'] );
 
@@ -604,11 +604,11 @@
                                /** @var PostRevision[] $historyGroup */
                                foreach( $historyGroup as $historyEntry ) {
                                        $postId = 
$historyEntry->getPostId()->getAlphadecimal();
-                                       if ( ! isset( 
$options['history'][$postId] ) ) {
-                                               $options['history'][$postId] = 
array();
+                                       if ( ! isset( 
$output['history'][$postId] ) ) {
+                                               $output['history'][$postId] = 
array();
                                        }
 
-                                       $options['history'][$postId][] = 
$historyEntry;
+                                       $output['history'][$postId][] = 
$historyEntry;
                                }
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/125953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4becd64221ca7abbcaf6a73b0dbcdcb21bc83695
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to