jenkins-bot has submitted this change and it was merged.
Change subject: Fix wonky WorldPay form loading
......................................................................
Fix wonky WorldPay form loading
Originally the form would appear to the right of the page instead
of to the left. This was caused by late application of the CSS.
Adding the worldpay module to the head of the document prevents
this problem.
Change-Id: I7657e6c7070d3c9b45ddd6be12f1b8f9d33ec861
---
M gateway_forms/rapidhtml/RapidHtmlResources.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Katie Horn: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_forms/rapidhtml/RapidHtmlResources.php
b/gateway_forms/rapidhtml/RapidHtmlResources.php
index abc3904..3f06a7c 100644
--- a/gateway_forms/rapidhtml/RapidHtmlResources.php
+++ b/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -305,6 +305,7 @@
'dependencies' => array ('di.form.core.validate', 'jquery.payment'),
'localBasePath' => dirname( __FILE__ ).'/../../worldpay_gateway/forms',
'remoteExtPath' => $wgWorldPayRapidHtmlRemoteExtPath,
+ 'position' => 'top',
);
$wgResourceModules[ 'basicDonationForm' ] = array(
--
To view, visit https://gerrit.wikimedia.org/r/126173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7657e6c7070d3c9b45ddd6be12f1b8f9d33ec861
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
