Amire80 has uploaded a new change for review. https://gerrit.wikimedia.org/r/126985
Change subject: Fix the tests for the entry point dialog ...................................................................... Fix the tests for the entry point dialog Change-Id: I3f56bb5842b74dc6cfcd6a8c086125004d06554d --- M tests/browser/features/red_link_anon.feature M tests/browser/features/red_link_dialog.feature M tests/browser/features/red_link_logged_in.feature M tests/browser/features/step_definitions/red_link_steps.rb M tests/browser/features/support/pages/red_link_page.rb 5 files changed, 10 insertions(+), 15 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/85/126985/1 diff --git a/tests/browser/features/red_link_anon.feature b/tests/browser/features/red_link_anon.feature index 9d30808..c2accfb 100644 --- a/tests/browser/features/red_link_anon.feature +++ b/tests/browser/features/red_link_anon.feature @@ -1,13 +1,13 @@ Feature: New translation from interlanguage link - As a wiki editor + As a registered wiki editor who uses a wiki in a different language I can initiate a translation directly from the content page, so that I can immediately discover how to contribute. Design: - http://pauginer.github.io/prototype-uls/#mies - These scenarios check the main entry point to the Special:ContentTranslation page. + These scenarios check that anonymous users don't see any red interlanguage links. Scenario: Anonymous user using the wiki's content language viewing a page that doesn't have a corresponding page in the target language Given I am on a page with an interlanguage link to "da" diff --git a/tests/browser/features/red_link_dialog.feature b/tests/browser/features/red_link_dialog.feature index b711edd..fcb3cde 100644 --- a/tests/browser/features/red_link_dialog.feature +++ b/tests/browser/features/red_link_dialog.feature @@ -1,6 +1,6 @@ Feature: New translation from interlanguage link - As a wiki editor + As a registered wiki editor who uses a wiki in a different language I can initiate a translation directly from the content page, so that I can immediately discover how to contribute. diff --git a/tests/browser/features/red_link_logged_in.feature b/tests/browser/features/red_link_logged_in.feature index 3c10e29..d1fcb9c 100644 --- a/tests/browser/features/red_link_logged_in.feature +++ b/tests/browser/features/red_link_logged_in.feature @@ -1,6 +1,6 @@ Feature: New translation from interlanguage link - As a wiki editor + As a registered wiki editor who uses a wiki in a different language I can initiate a translation directly from the content page, so that I can immediately discover how to contribute. diff --git a/tests/browser/features/step_definitions/red_link_steps.rb b/tests/browser/features/step_definitions/red_link_steps.rb index 1b0f045..d5c489e 100644 --- a/tests/browser/features/step_definitions/red_link_steps.rb +++ b/tests/browser/features/step_definitions/red_link_steps.rb @@ -9,8 +9,7 @@ end When(/^I click on the red link to "(.*?)" in the list of the interlanguage links$/) do |autonym| - sleep 5 - on(RedLinkPage).red_interlanguage_link_with_autonym(autonym).click + on(RedLinkPage).red_interlanguage_item_with_autonym(autonym).click end When(/^I click outside of the red link dialog$/) do @@ -29,14 +28,14 @@ on(RedLinkPage).translated_title_element.when_visible.click end -When(/^I click on the X button in the dialog for creating a page in "(.+?)"$/) do |autonym| - on(RedLinkPage).dialog_close_button(autonym).click +When(/^I click on the X button in the red link dialog$/) do + on(RedLinkPage).dialog_close_button.click end When(/^I set "(.*?)" as the interface language$/) do |code| on(RedLinkPage) do |page| page.trigger_cog_element.click - page.uls_more_languages_element.click + page.uls_more_languages_element.when_present.click page.language_filter = code # Because one browser wants :enter and other :return -- sigh page.language_filter_element.send_keys [:enter, "\n"] diff --git a/tests/browser/features/support/pages/red_link_page.rb b/tests/browser/features/support/pages/red_link_page.rb index fad2199..b4d501c 100644 --- a/tests/browser/features/support/pages/red_link_page.rb +++ b/tests/browser/features/support/pages/red_link_page.rb @@ -35,8 +35,8 @@ @browser.li(class: "interlanguage-link", text: autonym) end - def dialog_close_button(autonym) - page_creation_dialog(autonym).span(class: "cx-icon-close") + def dialog_close_button + @browser.span(css: ".cx-entrypoint-dialog:not(.hidden) .icon-close") end def page_creation_dialog(autonym) @@ -48,9 +48,5 @@ def red_interlanguage_item_with_autonym(autonym) @browser.li(class: "cx-new-interlanguage-link", text: autonym) - end - - def red_interlanguage_link_with_autonym(autonym) - red_interlanguage_item_with_autonym(autonym).a end end -- To view, visit https://gerrit.wikimedia.org/r/126985 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f56bb5842b74dc6cfcd6a8c086125004d06554d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
