Severin Anatoliy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/127203

Change subject: fix bug in 'savenewthread' action
......................................................................

fix bug in 'savenewthread' action

code expect WFThread object to call show()
but addThread() uses WFThread::add which return string and call show() itself

Change-Id: Ief7354438d2cf53a8b7101d44161300058585465
---
M SpecialWikiForum.php
1 file changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiForum 
refs/changes/03/127203/1

diff --git a/SpecialWikiForum.php b/SpecialWikiForum.php
index d3197cc..7d97c06 100644
--- a/SpecialWikiForum.php
+++ b/SpecialWikiForum.php
@@ -150,10 +150,7 @@
                                                                $output .= 
$forum->showNewThreadForm();
                                                                break;
                                                        case 'savenewthread':
-                                                               $thread = 
$forum->addThread( $title, $text );
-                                                               if ( $thread ) {
-                                                                       $output 
.= $thread->show();
-                                                               }
+                                                               $output .= 
$forum->addThread( $title, $text );
                                                                break;
 
                                                        default:

-- 
To view, visit https://gerrit.wikimedia.org/r/127203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief7354438d2cf53a8b7101d44161300058585465
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiForum
Gerrit-Branch: master
Gerrit-Owner: Severin Anatoliy <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to